jaxxstorm / aws-sso-creds

Get AWS SSO temporary creds from an SSO profile
MIT License
186 stars 24 forks source link

Improve support for sso-session section in AWS config #32

Closed uvw closed 1 year ago

uvw commented 1 year ago

I took another stab at improving #16.

AWS CLI essentially merges the profile and referenced sso-session options with the profile taking precedence. I updated the code to do exactly this.

In the long run, a much better approach would be to upgrade to https://github.com/aws/aws-sdk-go-v2 and use https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/config#LoadDefaultConfig. But change has much larger scope than just merging "sso_" options in the right order ;)

jaxxstorm commented 1 year ago

Looks awesome!