search

jaxxstorm / hookpick

A tool to manage some operational concepts of Hashicorp Vault
MIT License
84 stars 14 forks source link

Adding Dockerfile and instructions #24

Open emcniece opened 6 years ago

emcniece commented 6 years ago

Introduces a simple Dockerfile for increased platform portability.

The Dockerfile is a 2-stage build, resulting in a minimal Alpine Linux image. Though it is not necessary to specify, the GOOS and GOARCH build arguments are provided for future cross-platform build capability.

The Makefile has 2 new platform-specific build commands, a docker build example, a docker run example, and a release task to push images to Docker Hub. If you feel that this PR is acceptable, it would be best for you to run the make image and make release commands so that the resulting image ends up under your own user. It would be even better to link the Github repo to the Docker Hub repo so that builds are automated and make release isn't necessary.

emcniece commented 6 years ago

Haah... I see that you just added a Dockerfile today! Nice work.

Are there any ideas from this PR that you find useful?

jaxxstorm commented 6 years ago

If you rebase the Dockerfile, I'm happy to merge this as yours is better

emcniece commented 6 years ago

I noticed you removed the Makefile too... should that stay deleted?

jaxxstorm commented 6 years ago

Sorry to nitpack. Couple things:

The docker build stuff is now automated by goreleaser, so probably don't need that in the Makefile.

It'd be good to keep the WORKDIR outside of /root.