search

jay-babu / mason-nvim-dap.nvim

GNU Affero General Public License v3.0
526 stars 37 forks source link

js-debug-adapter #127

Closed cr4ftx closed 3 months ago

cr4ftx commented 5 months ago

Hi there,

Thanks for this plugins đź‘Ť

I have an issue when I configure the js-debug-adapter, this plugin maps js to js-debug-adapter.

But on the other hand, the js-debug-adapter only accept pwa-node, pwa-chrome, pwa-msedge, node-terminal, pwa-extensionHost.

So if I add an adapter like this : dap.adapters["pwa-node"] the auto install feature is not working (it expects js).

I managed to add js in the ensure_installed but I wanted to auto install adapters.

Is there any solution to this ?

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

github-actions[bot] commented 4 months ago

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

jay-babu commented 4 months ago

@cr4ftx does the above PR meet your needs? It should from what I see

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

cr4ftx commented 4 months ago

Yeah it's going to do the job, but there are other options than pwa-node from what I can see from here https://code.visualstudio.com/docs/nodejs/nodejs-debugging and here https://github.com/mxsdev/nvim-dap-vscode-js. I think someone should deep dive all of the options of the js-debug-adapter.

nvim-dap has already an option for loading vscode config (see :h dap.ext.vscode.load_launchjs) I think supporting this config would be awesome.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

github-actions[bot] commented 3 months ago

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.