Closed mehalter closed 5 months ago
require('mason-nvim-dap.mappings.filetypes'))
isn't complete and misses some very basic types actually.
I had found few for node-js and fixed in LazyVIM: https://github.com/LazyVim/LazyVim/pull/3165/files
But if this repo is going to take the responsibility of configuring the vscode extension, it should add these mappings also.
( I may myself raise PR, but not getting time. So, will be good if someone else can take it up )
Those adapters are not handled by this plugin so it makes no sense for this plugin to add those mappings. It would be up to the user or whatever plugin creates those types to add it to this same structure.
Looking at the LazyVim code, the "pwa-node"
and "node"
adapters are defined in the typescript extra in LazyVim itself. So it would be up to them to add those mappings. The adapter names are completely arbitrary and set up by the user or whatever so we cannot just make up random adapter names and set filetypes for them.
@80avin here is a PR on LazyVim that fixes their configuration of vscode types: https://github.com/LazyVim/LazyVim/pull/3556
nvim-dap
provides a vscode extension that loads inlaunch.json
files. It has an internal variable for the mappings from adapters to filetypes when loading configurations. This adds automatic support to connect the filetypes to the adapters defined bynvim-dap
Here is the variable: https://github.com/mfussenegger/nvim-dap/blob/master/lua/dap/ext/vscode.lua#L6
And here is where they use it: https://github.com/mfussenegger/nvim-dap/blob/master/lua/dap/ext/vscode.lua#L197