jay0lee / oneTwoOne

Prevent students from logging into other's Chromebook
Apache License 2.0
20 stars 9 forks source link

Migrate from Manifest V2 to V3 ahead of potential issues. #7

Open matthttam opened 1 year ago

matthttam commented 1 year ago

https://developer.chrome.com/blog/more-mv2-transition/#:~:text=In%20June%202023%2C%20the%20Chrome,their%20visibility%20changed%20to%20Unlisted.

matthttam commented 1 year ago

I'm assuming after 4 years of no updates that this project may be abandoned. I've forked it to my own that is currently specific to how I use it however I plan on making it configurable and possibly adding it to the store.

I ended up having to rewrite pretty much all the code due to the v2 to v3 changes. This can be found here: https://github.com/matthttam/oneTwoOne

Hopefully this helps people!

jay0lee commented 1 year ago

Glad to see it @matthttam. As you mentioned I simply don't have time to maintain this any longer.

If a few other admins can test your fork and confirm everything is working for them I'm happy to redirect to your fork.

Jay Lee

On Wed, Apr 12, 2023 at 4:49 PM matthttam @.***> wrote:

I'm assuming after 4 years of no updates that this project may be abandoned. I've forked it to my own that is currently specific to how I use it however I plan on making it configurable and possibly adding it to the store.

I ended up having to rewrite pretty much all the code due to the v2 to v3 changes. This can be found here: https://github.com/matthttam/oneTwoOne

Hopefully this helps people!

— Reply to this email directly, view it on GitHub https://github.com/jay0lee/oneTwoOne/issues/7#issuecomment-1505917916, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMFHYCBCCKUTNDQ4L5LXA4IMHANCNFSM6AAAAAAW2VXJAE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

matthttam commented 1 year ago

Sounds good! I actually just finished deploying to 5000 students so fingers crossed it works!

I'll give it a few days and if everything is working as expected you can link then if you'd like.

Matt

jennmix commented 1 year ago

@matthttam Love to hear an update on the deployment.

GuruGabe commented 1 year ago

@matthttam I have a question about your background.js file but don't know how to comment on your page. In background.js you have coded if (data.location.some(location => location.endsWith('@owensboro.kyschools.us'))) { console.log('Device assigned to a staff member, not blocking anything.'); return; } so I don't know if that will effect anyone else that uses it outside your district.

reardonp-fps commented 2 months ago

We will be testing this in the coming 24-25 school year ourselves. Pushing as many v3 extensions as possible to try to sunset on Google's public timeline. Initial tests look good! Real test in September.

matthttam commented 2 months ago

@matthttam I have a question about your background.js file but don't know how to comment on your page. In background.js you have coded if (data.location.some(location => location.endsWith('@owensboro.kyschools.us'))) { console.log('Device assigned to a staff member, not blocking anything.'); return; } so I don't know if that will effect anyone else that uses it outside your district.

Just letting you know, my latest version removes that in lieu of the ability to configure the app. That bit was a stopgap that we needed quickly and it wouldn't really affect other districts.

matthttam commented 2 months ago

We will be testing this in the coming 24-25 school year ourselves. Pushing as many v3 extensions as possible to try to sunset on Google's public timeline. Initial tests look good! Real test in September.

@jay0lee @reardonp-fps

I published an updated fork of this extension that is working quite well. https://chromewebstore.google.com/detail/onetwoone-lockdown/djkcpblgmmdnielnpleekpaliebjhdgc?pli=1

Let me know if you have any issues!