Tom-the-Bomb commented 3 years ago

some emojis arent square ™️ very sus pr

jay3332 commented 3 years ago

SMH decrease code quality Also make the same changes to the async directory

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 40.72%.

Quality metrics	Before	After	Change
Complexity	0.44 ⭐	14.80 🙂	14.36 👎
Method Length	21.20 ⭐	56.50 ⭐	35.30 👎
Working memory	7.00 🙂	17.82 ⛔	10.82 👎
Quality	86.11% ⭐	45.39% 😞	-40.72% 👎

Other metrics	Before	After	Change
Lines	38	103	65

Changed files	Quality Before	Quality After	Quality Change
pilmoji/sync/core.py	86.11% ⭐	45.39% 😞	-40.72% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
pilmoji/sync/core.py	Pilmoji.text	23 😞	233 ⛔	24 ⛔	22.11% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pilmoji/sync/core.py	Pilmoji.__init__	1 ⭐	53 ⭐	13 😞	69.81% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.