jay3332 / pilmoji

Pilmoji is a fast and reliable emoji renderer for PIL.
MIT License
77 stars 28 forks source link

fix for emoji==2.0.0 #13

Closed owocado closed 2 years ago

owocado commented 2 years ago

Hi,

this PR adds fix needed for emoji lib (==2.0.0) as we discussed in DM.

Also resolves #12

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.54%.

Quality metrics Before After Change
Complexity 6.29 ⭐ 6.17 ⭐ -0.12 👍
Method Length 51.33 ⭐ 52.33 ⭐ 1.00 👎
Working memory 8.82 🙂 9.00 🙂 0.18 👎
Quality 69.49% 🙂 68.95% 🙂 -0.54% 👎
Other metrics Before After Change
Lines 140 141 1
Changed files Quality Before Quality After Quality Change
pilmoji/init.py 98.67% ⭐ 98.67% ⭐ 0.00%
pilmoji/helpers.py 68.13% 🙂 67.60% 🙂 -0.53% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pilmoji/helpers.py getsize 10 🙂 95 🙂 13 😞 54.78% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

jay3332 commented 2 years ago

sorry for that, it appears it works fine for emoji<2, so the requirement isn't actually needed. Sorry for the hassle

owocado commented 2 years ago

oh sorry. I reverted the commit relating to requirements.txt changes! 👍🏼