search

jaybee84 / ml-in-rd

Manuscript for perspective on machine learning in rare disease
Other
2 stars 1 forks source link

revisions from read through #109

Closed cgreene closed 4 years ago

cgreene commented 4 years ago

Purpose

88

Directions for reviewers

Which areas should receive a particularly close look?

I changed a few things, but mostly inserted todos. I think we should figure out if we want to have a "bringing things together" section or not. I think we should, but it means a bit of a light restructuring.

Is there anything that you want to discuss further?

The TODOs :)

Is the pull request ready for review?

Yes.

Manuscript checklist

Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.207 for commit da36549761ae1ae0997441955b22b7cd946b06e7 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.208

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.209 for commit 89289b635afae2eb003a2f37a5eaa8e5b9f89beb is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

jaybee84 commented 4 years ago

Added #112 to track regularization.

The TODOs in the heterogeneity section refers to refs and some rewriting, which may be easy to resolve in the context of this PR? @allaway thoughts?

cgreene commented 4 years ago

I am fine with merging this and then addressing the outstanding issues, but I'll wait to merge :)

allaway commented 4 years ago

LGTM to merge!

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.210 for commit f83409d360b5b1b74db93905a8f423305f0f98d5 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at: