search

jaybee84 / ml-in-rd

Manuscript for perspective on machine learning in rare disease
Other
2 stars 1 forks source link

update heterogeneity + rep learning sections #119

Closed allaway closed 4 years ago

allaway commented 4 years ago

Purpose

closes #113 and #115

Directions for reviewers

Make sure I addressed the two issues as well as the inline todos appropriately. I added a few TODOs/NOTEs where I wasn't sure what to do.

Which areas should receive a particularly close look?

The new TODOs I added.

Is there anything that you want to discuss further?

There were a couple of comments that I didn't understand:

<!-- TODO: Refs! --> on L43 of the new version - what is this referring to? where is the missing ref?

<!-- TODO: Make reference to the dimensionality reduction section above --> on L53 of the new version - I was not clear what the reference here was supposed to be/what it is supposed to provide for the reader - also not sure who made this comment - @cgreene or @jaclyn-taroni ?

Is the pull request ready for review?

I think this is ready for a first pass review- please feel free to comment or add suggestions.

Manuscript checklist

Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.236 for commit 7fefdd289a37939f4719126a121e287bd4fa7c50 is now complete.

Found 1 potential spelling error(s). Preview:content/05.prior-knowledge.md:50:underperform...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.237 for commit b32fcae78ba9b7049f68182adb4b36712887fab8 is now complete.

Found 4 potential spelling error(s). Preview:content/03.heterogeneity.md:3:vanishingly content/03.heterogeneity.md:4:mRNA content/03.heterogeneity.md:18:structrue content/05.prior-knowledge.md:50:underperform...
The rendered manuscript from this build is temporarily available for download at:

allaway commented 4 years ago

Alternate section title: https://www.youtube.com/watch?v=gj3dPe2vJHo

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.238 for commit 418a6c686a13cc3771ac332d021dce7b9831544f is now complete.

Found 4 potential spelling error(s). Preview:content/03.heterogeneity.md:3:vanishingly content/03.heterogeneity.md:4:mRNA content/03.heterogeneity.md:18:structrue content/05.prior-knowledge.md:50:underperform...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.239 for commit 35759bf78072a9b5d222ad5fab4d58fe0d1b701d is now complete.

Found 4 potential spelling error(s). Preview:content/03.heterogeneity.md:3:vanishingly content/03.heterogeneity.md:4:mRNA content/03.heterogeneity.md:18:structrue content/05.prior-knowledge.md:50:underperform...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.240 for commit 3eeb6adbdc48d5d4804c8ba8683ee91560948354 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

jaybee84 commented 4 years ago

Re: <-- TODO: Refs! on L43 of the new version - what is this referring to? where is the missing ref?>

I think this was referring to the section where you had discussed tapping into domain knowledge of experts (in the context of surgical procedures introducing technical/biological artifacts in the data) as one of the things people should consider while working with rare disease data.

allaway commented 4 years ago

Re: <-- TODO: Refs! on L43 of the new version - what is this referring to? where is the missing ref?>

I think this was referring to the section where you had discussed tapping into domain knowledge of experts (in the context of surgical procedures introducing technical/biological artifacts in the data) as one of the things people should consider while working with rare disease data.

That's what I thought at first too, but that had it's own "add ref" note, so I thought this one might be referring to something else.

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.241 for commit 1b340607d65dffdfeae90eaa1123409a9c36803c is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.242 for commit 98c99e48807daf91a6fc50e5279558fe67f9337f is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

allaway commented 4 years ago

I realize this is still in prep, but I added a few comments and preliminary edits. :)

That's great - thank you!

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.243 for commit e04794f38f77acb6b63bad3df384e86d9d61f223 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.244 ... for commit d1e568f9a309b61a20e573faf29c17d6ab7a408b is now complete.

Found 0 potential spelling error(s). Preview: The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.245 for commit 6265a6a1073ad4901234d010ceea997b9bd140f8 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.246 for commit 3661bf4acb2a7eee62ea7281345248a4e5d1e975 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 4 years ago

AppVeyor build 1.0.247 for commit b4bf3ea977434193a399f1c006e5748ae21dfcb6 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at: