Added 3. figures - Githubissues

I had a question, for the figures with multiple sub-figures, should we add A.<title> B.` so it is easier to refer to them while writing/reading? </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jaclyn-taroni"><img src="https://avatars.githubusercontent.com/u/19534205?v=4" />jaclyn-taroni</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>I had a question, for the figures with multiple sub-figures, should we add <code>A.<title></code> B.<title>` so it is easier to refer to them while writing/reading?</p> </blockquote> <p>I think we should add lettering to the panels, e.g., <code>A</code> and <code>B</code>, and we will need to number the figures to refer to them in the text. Any titles should come in the figure legends in my opinion.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dvenprasad"><img src="https://avatars.githubusercontent.com/u/15315514?v=4" />dvenprasad</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>Ah I see. To clarify, for example in the transfer learning panel, we would replace the title <code>Transfer Learning</code> with <code>A</code> ?</p> <p><img src="https://user-images.githubusercontent.com/15315514/105402074-f675df80-5bf4-11eb-8ade-b967e09230ea.png" alt="Screen Shot 2021-01-21 at 2 27 55 PM" /></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jaclyn-taroni"><img src="https://avatars.githubusercontent.com/u/19534205?v=4" />jaclyn-taroni</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>Ah, I see what you mean by title. I think it's fine to leave <code>Transfer Learning</code> in in that case, but I would add <code>A</code> separately (probably larger and in a different font).</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dvenprasad"><img src="https://avatars.githubusercontent.com/u/15315514?v=4" />dvenprasad</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>Okay. phew! I was very very confused. Okay, will add those in.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/AppVeyorBot"><img src="https://avatars.githubusercontent.com/u/17834419?v=4" />AppVeyorBot</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>AppVeyor <a href="https://ci.appveyor.com/project/jaybee84/ml-in-rd/builds/37423866">build 1.0.321</a> for commit d1d2f852ef9965941642fd606fa0ae5cec81e2fe is now complete. <details><summary>Found 6 potential spelling error(s). Preview:</summary>content/05.prior-knowledge.md:25:TODO content/06.multiple-approaches-required.md:12:TODO content/06.multiple-approaches-required.md:13:VAE's content/06.multiple-approaches-required.md:15:TODO content/06.multiple-approaches-required.md:16:histopathology content/07.definitions.md:4:TODO... </details> The rendered manuscript from this build is temporarily available for download at:</p> <ul> <li><a href="https://ci.appveyor.com/api/buildjobs/mkyqk0cbgctpdo5o/artifacts/manuscript-1.0.321-d1d2f85.html"><code>manuscript-1.0.321-d1d2f85.html</code></a> <ul> <li><a href="https://ci.appveyor.com/api/buildjobs/mkyqk0cbgctpdo5o/artifacts/manuscript-1.0.321-d1d2f85.pdf"><code>manuscript-1.0.321-d1d2f85.pdf</code></a></li> <li><a href="https://ci.appveyor.com/api/buildjobs/mkyqk0cbgctpdo5o/artifacts/spelling-errors-1.0.321-d1d2f85.txt"><code>spelling-errors-1.0.321-d1d2f85.txt</code></a></li> <li><a href="https://ci.appveyor.com/api/buildjobs/mkyqk0cbgctpdo5o/artifacts/spelling-error-locations-1.0.321-d1d2f85.txt"><code>spelling-error-locations-1.0.321-d1d2f85.txt</code></a></li> </ul></li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jaybee84"><img src="https://avatars.githubusercontent.com/u/17917521?v=4" />jaybee84</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>@jaybee84 to look up figure requirements in the target journal</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jaybee84"><img src="https://avatars.githubusercontent.com/u/17917521?v=4" />jaybee84</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>The guidelines for dimensions of figures are as follows:</p> <p><code>All panels of a figure or table (for example, Fig. 1a, b and c) should be combined into one file; please do not send as separate files. Image files should be just large enough to view when the screen resolution is set to 640 x 480 pixels. Remember to include a brief title and legend (preferably incorporated into the image file to appear near the image) as part of every electronic figure submitted, and a title as part of every table.</code></p> <p>For more details see #90 </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dvenprasad"><img src="https://avatars.githubusercontent.com/u/15315514?v=4" />dvenprasad</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <ul> <li>added a. <title> on panels</li> <li>adjusted to figure specifications</li> <li>moved figures to image directory</li> <li>added pdfs and tiffs of the figures</li> <li>addressed comments on PR.</li> </ul> <p>The ensemble learning panel is still a bit iffy when resized. I'm not sure what we can do without modifying the figure somewhat</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/AppVeyorBot"><img src="https://avatars.githubusercontent.com/u/17834419?v=4" />AppVeyorBot</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>AppVeyor <a href="https://ci.appveyor.com/project/jaybee84/ml-in-rd/builds/37502702">build 1.0.331</a> for commit 33bb0b5cc9736f371b64f664d9baa1b961bd5f1b is now complete. <details><summary>Found 6 potential spelling error(s). Preview:</summary>content/05.prior-knowledge.md:25:TODO content/06.multiple-approaches-required.md:12:TODO content/06.multiple-approaches-required.md:13:VAE's content/06.multiple-approaches-required.md:15:TODO content/06.multiple-approaches-required.md:16:histopathology content/07.definitions.md:4:TODO... </details> The rendered manuscript from this build is temporarily available for download at:</p> <ul> <li><a href="https://ci.appveyor.com/api/buildjobs/o0toech7n9nikow9/artifacts/manuscript-1.0.331-33bb0b5.html"><code>manuscript-1.0.331-33bb0b5.html</code></a> <ul> <li><a href="https://ci.appveyor.com/api/buildjobs/o0toech7n9nikow9/artifacts/manuscript-1.0.331-33bb0b5.pdf"><code>manuscript-1.0.331-33bb0b5.pdf</code></a></li> <li><a href="https://ci.appveyor.com/api/buildjobs/o0toech7n9nikow9/artifacts/spelling-errors-1.0.331-33bb0b5.txt"><code>spelling-errors-1.0.331-33bb0b5.txt</code></a></li> <li><a href="https://ci.appveyor.com/api/buildjobs/o0toech7n9nikow9/artifacts/spelling-error-locations-1.0.331-33bb0b5.txt"><code>spelling-error-locations-1.0.331-33bb0b5.txt</code></a></li> </ul></li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/AppVeyorBot"><img src="https://avatars.githubusercontent.com/u/17834419?v=4" />AppVeyorBot</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>AppVeyor <a href="https://ci.appveyor.com/project/jaybee84/ml-in-rd/builds/37504880">build 1.0.333</a> for commit 095bba75741acc4fe8a69b75081a0a29ff3224d9 is now complete. <details><summary>Found 8 potential spelling error(s). Preview:</summary>content/05.prior-knowledge.md:25:TODO content/06.multiple-approaches-required.md:12:TODO content/06.multiple-approaches-required.md:13:VAE's content/06.multiple-approaches-required.md:15:TODO content/06.multiple-approaches-required.md:16:histopathology content/07.definitions.md:4:TODO content/08.outlook.md:24:genotypic content/08.outlook.md:45:mahadeva... </details> The rendered manuscript from this build is temporarily available for download at:</p> <ul> <li><a href="https://ci.appveyor.com/api/buildjobs/sl4t5v19t0pv7ykb/artifacts/manuscript-1.0.333-095bba7.html"><code>manuscript-1.0.333-095bba7.html</code></a> <ul> <li><a href="https://ci.appveyor.com/api/buildjobs/sl4t5v19t0pv7ykb/artifacts/manuscript-1.0.333-095bba7.pdf"><code>manuscript-1.0.333-095bba7.pdf</code></a></li> <li><a href="https://ci.appveyor.com/api/buildjobs/sl4t5v19t0pv7ykb/artifacts/spelling-errors-1.0.333-095bba7.txt"><code>spelling-errors-1.0.333-095bba7.txt</code></a></li> <li><a href="https://ci.appveyor.com/api/buildjobs/sl4t5v19t0pv7ykb/artifacts/spelling-error-locations-1.0.333-095bba7.txt"><code>spelling-error-locations-1.0.333-095bba7.txt</code></a></li> </ul></li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dvenprasad"><img src="https://avatars.githubusercontent.com/u/15315514?v=4" />dvenprasad</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>Personally I am okay with the grey boxes but I added lines because of this figure guideline</p> <blockquote> <p>All display items should be on a white background, and should avoid excessive boxing, unnecessary colour, spurious decorative effects</p> </blockquote> <p>I interpreted this to mean white background for all panels and the figure itself. Maybe I misinterpreted? </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jaybee84"><img src="https://avatars.githubusercontent.com/u/17917521?v=4" />jaybee84</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>Ah! got it... you probably interpreted it correctly... we can pick up on this during our round robins :)</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

jaybee84 / ml-in-rd

Added 3. figures #142

Purpose

Directions for reviewers

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the pull request ready for review?

Manuscript checklist