jaybee84 / ml-in-rd

Manuscript for perspective on machine learning in rare disease
Other
2 stars 1 forks source link

First pass at revising the introduction #183

Closed jaclyn-taroni closed 2 years ago

jaclyn-taroni commented 3 years ago

Purpose

Starts to address #173. I'm not totally happy with this yet, but wanted to get more 👀 on it so folks can see the general direction I am going in.

Quoting https://github.com/jaybee84/ml-in-rd/issues/173#issuecomment-887619198, as that's what I thought we should do when I re-read this for the first time in a while:

  • In referencing the systematic review on application of ML in RD, remove the references to specific approaches (e.g., SVM) and just stick to the number of studies and diseases
  • Define machine learning and move descriptions of unsupervised and supervised machine learning from the "definitions" section to the intro and integrate them in the following ways:
    • Use a specific example (or two) of supervised machine learning applications in this context. Tie this into gold and silver standard discussion. Can also use a specific example here that's about precision medicine in common diseases if we'd like.
    • Likewise, what's a specific example of how one would use unsupervised machine learning in this context? That should come right after the definition of unsupervised machine learning.
  • When we talk about bad things ™️ that can happen like unstable performance - what would that look like in someone's hands (e.g., in practice)? Why is that bad?

I think I've covered a lot of these in this draft, but I also don't know if folks agreed with these takes!

Directions for reviewers

Manuscript checklist

Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.

AppVeyorBot commented 3 years ago

AppVeyor build 1.0.441 for commit 047858aa2813b1eef043f5a6fd339e923d4ce1ad is now complete.

Found 5 potential spelling error(s). Preview:content/02.intro.md:5:TODO content/02.intro.md:8:TODO content/02.intro.md:13:subtypes content/02.intro.md:17:hierchical content/02.intro.md:18:subtype...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 3 years ago

AppVeyor build 1.0.442 for commit 5d0ae6d3f007a19a0deaa9b639b50516f25497fe is now complete.

Found 2 potential spelling error(s). Preview:content/02.intro.md:5:TODO content/02.intro.md:8:TODO...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.445 for commit 4e652f9bb16ee64aa07dc86e1593846ad965c2ac is now complete.

Found 1 potential spelling error(s). Preview:content/02.intro.md:8:TODO...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.446 for commit bf0f5132149269d4f8fa7d897bba64806e6887ea is now complete.

Found 1 potential spelling error(s). Preview:content/02.intro.md:8:TODO...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.447 for commit bf0f5132149269d4f8fa7d897bba64806e6887ea is now complete.

Found 1 potential spelling error(s). Preview:content/02.intro.md:8:TODO...
The rendered manuscript from this build is temporarily available for download at:

jaclyn-taroni commented 2 years ago

Thank you for the review @allaway! In many cases I committed your changes directly, but I also attempted to make edits in the spirit of your review in some cases.

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.448 for commit 3bb33c935b8ab2ae4cedb71219efabdc01d6e9a3 is now complete.

Found 4 potential spelling error(s). Preview:content/02.intro.md:6:TODO content/02.intro.md:9:responder content/02.intro.md:9:responder content/02.intro.md:16:TODO...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.450

Found 4 potential spelling error(s). Preview:content/02.intro.md:6:TODO content/02.intro.md:9:responder content/02.intro.md:9:responder content/02.intro.md:16:TODO...
for commit 46442d0e6c8dda2b0a013b8121fa72d0a8b7b0c7 is now complete. The rendered manuscript from this build is temporarily available for download at:

jaybee84 commented 2 years ago

@allaway your approval is necessary for merging this request since you had requested changes :)