search

jaybee84 / ml-in-rd

Manuscript for perspective on machine learning in rare disease
Other
2 stars 1 forks source link

Breakout discussion of combining datasets into own section #188

Closed jaclyn-taroni closed 2 years ago

jaclyn-taroni commented 2 years ago

Purpose

Here I'm adding a first pass at breaking out the discussion of combining multiple datasets – previously contained in the section that covered dimensionality reduction – into its own section that will come right after the intro (#187). This is designed to complement the new box that will cover the basics of experimental design (#186).

Directions for reviewers

I would recommend looking at (or revisiting) #183 for context. That is intended to set the stage for our new audience and it's important that the content of this pull request is correctly pitched for the intended audience.

Which areas should receive a particularly close look?

I'm not happy about the wording in the last paragraph right now, so suggestions there are welcome in particular!

Is the pull request ready for review?

Yes. I don't expect that what gets merged will necessarily look like what I submit initially, but feedback at this stage seems warranted.

Manuscript checklist

Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.449 for commit 2536d1a6d0d0dc26fb8e582be84cf05e07cb3b95 is now complete.

Found 2 potential spelling error(s). Preview:content/03.combining-datasets.md:5:TODO content/03.combining-datasets.md:9:TODO...
The rendered manuscript from this build is temporarily available for download at:

jaybee84 commented 2 years ago

Contingent on #185

jaclyn-taroni commented 2 years ago

Based on conversation today: consider moving up some of the information in Emphasis on not just "more n" but "more meaningful n" section in Outlook.

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.455 for commit 2b9d2d669ea46bf6dd1928da44ed0163a9cc4362 is now complete.

Found 6 potential spelling error(s). Preview:content/02.intro.md:6:TODO content/02.intro.md:9:responder content/02.intro.md:9:responder content/02.intro.md:16:TODO content/03.combining-datasets.md:5:TODO content/03.combining-datasets.md:9:TODO...
The rendered manuscript from this build is temporarily available for download at:

jaybee84 commented 2 years ago

@jaclyn-taroni are you okay with resolving the above additions/comments?

jaclyn-taroni commented 2 years ago

Yup - I turned one of the comments from you into a suggestion proper and then included all suggestions in https://github.com/jaybee84/ml-in-rd/pull/188/commits/8ece24560eb565b62bc258c495889eccf9b6311c

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.456 for commit 8ece24560eb565b62bc258c495889eccf9b6311c is now complete.

Found 8 potential spelling error(s). Preview:content/02.intro.md:6:TODO content/02.intro.md:9:responder content/02.intro.md:9:responder content/02.intro.md:16:TODO content/03.combining-datasets.md:5:TODO content/03.combining-datasets.md:8:collinearity content/03.combining-datasets.md:8:collinearity content/03.combining-datasets.md:9:TODO...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.457 for commit 67ba2bcd9c696309ac31ce91a9d66bca4ba7b304 is now complete.

Found 8 potential spelling error(s). Preview:content/02.intro.md:6:TODO content/02.intro.md:9:responder content/02.intro.md:9:responder content/02.intro.md:16:TODO content/03.combining-datasets.md:5:TODO content/03.combining-datasets.md:8:collinearity content/03.combining-datasets.md:8:collinearity content/03.combining-datasets.md:9:TODO...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.458 for commit c3afd19d8ab1b53b6407c18bc43eb0f32fa689f5 is now complete.

Found 8 potential spelling error(s). Preview:content/02.intro.md:6:TODO content/02.intro.md:9:responder content/02.intro.md:9:responder content/02.intro.md:16:TODO content/03.combining-datasets.md:5:TODO content/03.combining-datasets.md:8:collinearity content/03.combining-datasets.md:8:collinearity content/03.combining-datasets.md:9:TODO...
The rendered manuscript from this build is temporarily available for download at:

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.463 for commit 4820343757f532f767579e30d2d3e7ccf33e9b66 is now complete.

Found 8 potential spelling error(s). Preview:content/02.intro.md:6:TODO content/02.intro.md:9:responder content/02.intro.md:9:responder content/02.intro.md:16:TODO content/03.combining-datasets.md:5:TODO content/03.combining-datasets.md:8:collinearity content/03.combining-datasets.md:8:collinearity content/03.combining-datasets.md:9:TODO...
The rendered manuscript from this build is temporarily available for download at: