search

jaybee84 / ml-in-rd

Manuscript for perspective on machine learning in rare disease
Other
2 stars 1 forks source link

Adding figure 3 #209

Closed dvenprasad closed 2 years ago

dvenprasad commented 2 years ago

Added: pdf, svg, and png formats

Purpose

https://github.com/jaybee84/ml-in-rd/issues/180

Directions for reviewers

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the pull request ready for review?

Manuscript checklist

Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.

jaybee84 commented 2 years ago

@dvenprasad the EHR icon looks a bit small compared to the other components. Would it be possible to scale it to match the size of the other components?

Also, maybe align the right margin of all the panels so that they all align (kind of like "justify" in a word doc ) :)

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.573 for commit 1240c4aacf4824c6a0bb3f87b280146770a3cd6b is now complete.

Found 7 potential spelling error(s). Preview:content/02.intro.md:12:TODO content/06.model-complexity.md:27:recalibrated content/06.model-complexity.md:36:Kullback content/06.model-complexity.md:36:Leibler content/06.model-complexity.md:36:luekemia content/06.model-complexity.md:41:WIP content/08.multiple-approaches-required.md:24:WIP...
The rendered manuscript from this build is temporarily available for download at:

dvenprasad commented 2 years ago

Yep, made those changes :)

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.574 for commit 40dc266e039040db7da5963a5dab5dd99101c070 is now complete.

Found 7 potential spelling error(s). Preview:content/02.intro.md:12:TODO content/06.model-complexity.md:27:recalibrated content/06.model-complexity.md:36:Kullback content/06.model-complexity.md:36:Leibler content/06.model-complexity.md:36:luekemia content/06.model-complexity.md:41:WIP content/08.multiple-approaches-required.md:24:WIP...
The rendered manuscript from this build is temporarily available for download at:

jaybee84 commented 2 years ago

@dvenprasad just checking with you about the above comment

dvenprasad commented 2 years ago

Oh I see that you say right aligned! (I've been reading it as left align all this while 🤦‍♀️ ) Yeah the items not aligning on right is a function of how much real estate each of the steps take. I am hesitant to stretch out the arrows or space between the steps just to line them up on the right because it would just add extra space and the other panels look weird. It would kinda look like justifying on word with only a few words on a line.

AppVeyorBot commented 2 years ago

AppVeyor build 1.0.596 for commit 59f9d4685779ad45c575471c585632d8504920b9 is now complete.

Found 4 potential spelling error(s). Preview:content/02.intro.md:13:TODO content/06.model-complexity.md:40:WIP content/08.multiple-approaches-required.md:24:WIP content/09.outlook.md:17:TODO...
The rendered manuscript from this build is temporarily available for download at: