Closed allaway closed 4 years ago
AppVeyor build 1.0.179 for commit 4690ba15d1fe5da910fc13433b1a433facdd270a is now complete. Found 1 potential spelling error(s). Preview:
content/04.model-complexity.md:3:additiopn...
AppVeyor build 1.0.182 for commit 567daf102765d4df8f14448a0ffc084b4f4287f0 is now complete.... Found 4 potential spelling error(s). Preview:
content/02.intro.md:10:subtantial
content/04.model-complexity.md:3:additiopn
content/05.prior-knowledge.md:27:mrare
content/05.prior-knowledge.md:30:comparator The rendered manuscript from this build is temporarily available for download at:
AppVeyor build 1.0.183 for commit 839b65a7d3c7151af519703ae49ce086d3dcb61c is now complete. Found 3 potential spelling error(s). Preview:
content/02.intro.md:10:subtantial
content/05.prior-knowledge.md:27:mrare
content/05.prior-knowledge.md:30:comparator...
AppVeyor build 1.0.184 for commit 0bc656164f50ccb01fc22b8d07d0857e06f6de57 is now complete. Found 0 potential spelling error(s). Preview:
...
AppVeyor build 1.0.191 for commit 2a9ddfc5b00c8d3cadaff61c7bcf28b9d4496dc8 is now complete. Found 0 potential spelling error(s). Preview:
...
Purpose
addresses #88 and closes #92 and closes #85
Directions for reviewers
Which areas should receive a particularly close look?
Did I cut anything mission critical?
Is there anything that you want to discuss further?
Yes:
The knowledge graph and representation learning sections seems like the could be moved into the same subheader as the transfer learning, etc section. I think that header has a good intro to this entire concept of "using prior knowledge"
I also feel as if the ensemble method section is pretty out of place here. But not sure how best to resolve it.
I also noted the Dincer et al manuscript was listed in two sections but only discussed in detail in one, was this on purpose? I think the second instance of it could be rewritten to remind the reader that this was discussed already.
Is the pull request ready for review?
yes
Manuscript checklist
Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.