jaycewhite / MiniMappingway

MIT License
5 stars 7 forks source link

Add option to hide during cutscene #17

Closed IUseExcessivelyLongUsernamesForNoReason closed 1 year ago

IUseExcessivelyLongUsernamesForNoReason commented 1 year ago

Feature request; would if be possible to please add an option to hide the dots during cutscenes?

Scrxtchy commented 1 year ago

was hiding the makers in cutscenes fixed in https://github.com/jaycewhite/MiniMappingway/commit/c2a4c681b1260cbbcf253a4c02748f3369844abf @jaycewhite? I wrote a patch for this myself sometime last year and never noticed a real fix, otherwise if this is still an issue in some cutscenes it could be improved

IUseExcessivelyLongUsernamesForNoReason commented 1 year ago

I do not think "fix" is the right word in this case. The addon works perfectly, this is a feature request, not a bug. That aside, I am still seeing dots during cutscenes, and there is no new option in the settings for it. No big deal though, it is such a small thing, and it is important to respect volunteer developers time. I would not have even checked back if github did not email me.

Scrxtchy commented 1 year ago

I would consider dots in cutscenes a bug, rather than a desirable feature that would be optional the only change I've made to my copy is how I check the visibility of the NaviMap image

https://github.com/goatcorp/FFXIVClientStructs/blob/main/FFXIVClientStructs/FFXIV/Component/GUI/AtkUnitBase.cs/#L39-L43

this just has changed which value the flags are compared to

    public bool IsVisible
    {
        get => (Flags & 0x20) == 0x20;
        set => Flags = value ? Flags |= 0x20 : Flags &= 0xDF;
    }
jaycewhite commented 1 year ago

Hi! I kinda didn't look at this github for a while until 6.3, so apologies for not looking at this sooner! I'm currently pretty busy because i've just moved, but once I get my pc setup etc. and I have a minute i'll read through to comments properly and see what I can do! Thanks!

jaycewhite commented 1 year ago

Closing this RE: #23