search

jaycewhite / MiniMappingway

MIT License
5 stars 7 forks source link

Do not throw out players when world visiting #22

Closed Scrxtchy closed 1 year ago

Scrxtchy commented 1 year ago

I didn't exactly know what this operation was calculating, but it was responsible for preventing PCs from being added to the Everyone section of the bag when the PC was world visiting. So, I have removed it from issuing a return from the function, but now it is a part of the check for requirements of the FC bag.

jaycewhite commented 1 year ago

Hi! I've tweaked this because I feel thats either there to check to pointer is valid, or as an optimisation so I don't compare the strings where there's no FC data. I pushed to this PR because I still wanted to be able to accept it as a fix since you identified the issue, hope thats ok!

Scrxtchy commented 1 year ago

Thanks for the merge, it's all okay, I did mention I didn't understand the operation as such so your insight into it to make it function in the optimal way is much appreciated 👍🏻