LTS Upgrade - Githubissues

jayco / accept-language-negotiator

RFC4647 compliant accept-language negotiator for parsing HTTP Accept-Language header and returning matched lists or language lookup.

MIT License

7 stars 3 forks source link

LTS Upgrade #2

Closed jayco closed 5 years ago

jayco commented 5 years ago

Overview: Changes in Node 11 to the way the sort params order in an arrays are passed in see https://github.com/nodejs/node/issues/24294 surfaced a bug in sorting.

Changes This PR changes the following:

sorts do not rely on order
- sorts now returns -1, 0, 1 (lt, eq, gt)
sort functions are now more readable and not so dense
remove excess function calls
add ci tests for each LTS
- 12
- 10
- 8