search

jaydeepw / poly-picker

Android library project for providing multiple image selection from the device.
406 stars 114 forks source link

Camera flash support #50

Open kaoskeya opened 9 years ago

kaoskeya commented 9 years ago

Hey, nice project. I tried this in a hobby project and works great.

One small issue though, the flash does not work (tried various combinations). Am I missing something or has it not been implemented? If it is one, if you could point me in some direction, I'd be happy to build it and send a PR.

Thank you!

jaydeepw commented 9 years ago

Support for camera flash is not present at the moment. I am using this https://github.com/commonsguy/cwac-camera by Commonsguy to show camera preview in the app.

Please go through above link and make the changes in https://github.com/jaydeepw/poly-picker/blob/master/PolyPicker/app/src/main/java/nl/changer/polypicker/CwacCameraFragment.java

Please follow style guide and write the code that is in harmony with existing code. One more thing. Thanks for the support. :)

kaoskeya commented 9 years ago

Hey Jaydeep,

I've made changes to the demo project and tested it on a few devices. The FLASH_MODE_TORCH and FLASH_MODE_ON gave quite a headache on different devices, but I've put together something.

Could you review it at https://github.com/jaydeepw/poly-picker/compare/master...kaoskeya:master, if you think it looks alright, I shall change the package CwacCameraFragment.java file and send you a PR. If you'd like something changed, do let me know.

I've been doing Java for a little while, please be nice if I've messed something up ;)

Thank you.

jaydeepw commented 9 years ago

Awesomeness! I am happy to see you implementing it. I will need some time though to take a look into this.

santoshjoshi commented 9 years ago

Thank You guys: i just implemented this change in my app. It Works great.

jaydeepw commented 9 years ago

can you send me a PR or can you put some code online so that I can implement it fast and make it available in public?

rondelserrano commented 9 years ago

How can i use this with ny eclipse juno?

On Jul 7, 2015 8:50 PM, "Jaydeep" notifications@github.com wrote:

can you send me a PR or can you put some code online so that I can implement it fast and make it available in public?

— Reply to this email directly or view it on GitHub.

jaydeepw commented 9 years ago

@rondelserrano https://github.com/jaydeepw/poly-picker#caution