search

jaydenmilne / steamsync

Tool to automatically add games from the Epic Games Launcher to Steam
GNU Affero General Public License v3.0
157 stars 17 forks source link

Some Xbox games not getting correct Game Name #19

Open jamierajewski opened 2 years ago

jamierajewski commented 2 years ago

While checking for Xbox games, I noticed a weird entry: frigateMS. Upon adding it to Steam, it got mapped to Octopath Traveler (which I do have installed). octopath

jamierajewski commented 2 years ago

This is due to the game name being incorrectly set in the game config, the actual title is in the Description:

<ShellVisuals DefaultDisplayName="FrigateMS"
              PublisherDisplayName="SQUARE ENIX CO. LTD."
              StoreLogo="Assets\StoreLogo.png"
              Square150x150Logo="Assets\Logo.png"
              Square44x44Logo="Assets\SmallLogo.png"
              Description="OCTOPATH TRAVELER"
              ForegroundText="dark"
              BackgroundColor="#000000"
              SplashScreenImage="Assets\SplashScreen.png"/>

I'm currently working on a PR to try and retrieve game names in a more consistent and robust way from just the appxmanifest.xml. It would be ideal to try in the MicrosoftGame.xml first, but with this example it looks like even when that exists it can still be incorrect whereas it always seems to be in order in appxmanifest.xml but I'm curious what you think.

jamierajewski commented 2 years ago

Fixed by #20