search

jaydenmilne / steamsync

Tool to automatically add games from the Epic Games Launcher to Steam
GNU Affero General Public License v3.0
157 stars 17 forks source link

Feature/legendary support #25

Closed dyyd closed 2 years ago

dyyd commented 2 years ago

Added option to install from legendary (https://github.com/derrod/legendary).

Allows to run EGS games with online support through Steam without opening EGS through URI call.

This should make it easier to use in Linux as well as legendary was initially meant for Linux usage.

jaydenmilne commented 2 years ago

Thanks for the MR! Couple quick things:

  1. Can you update the README to mention it supports Legendary, and also provide an example?
  2. Have you tested this on Linux? Curious if it works.
  3. I don't blame you for reverting GUI stuff, it's quite behind the CLI right now.
dyyd commented 2 years ago
  1. Sure, will do
  2. Not yet, don't have games on my Linux machine
  3. I simply didn't get the GUI working. I even tried building it in dedicated docker images but still no luck. Reverted for now until I can actually run it and validate stuff.

Developing on Linux or WSL and playing on Windows resulted in situation where the dev and use machines don't match.

I use legendary mainly to get account auth and drm working through Steam Link without the need to open up Epic Store.

jaydenmilne commented 2 years ago

One final thing, can you put legendary_collect_games in its own file? I'm trying to keep the non-egs collectors out of steamsync.py, Other than that, a few minor nits and this LGTM!

Thanks for contributing!

jaydenmilne commented 2 years ago

Also I'm jealous of your steam link :D

dyyd commented 2 years ago

Updated README, moved legendary collection function to separate file. Also made a few improvements to work in Linux.

If the empty shortcuts file change is too much for this MR then I can break it off into a separate one.

jaydenmilne commented 2 years ago

I’ve been very busy with some things in my personal life recently. I appreciate your contribution and will try and review it once the dust settles. Sorry for the delay.

On Feb 15, 2022, at 02:58, Tiit Kass @.***> wrote:

 Updated README, moved legendary collection function to separate file. Also made a few improvements to work in Linux.

If the empty shortcuts file change is too much for this MR then I can break it off into a separate one.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you commented.

jaydenmilne commented 2 years ago

Life is back to normal, thanks for the contribution, LGTM!