search

jaydenmilne / steamsync

Tool to automatically add games from the Epic Games Launcher to Steam
GNU Affero General Public License v3.0
157 stars 17 forks source link

Add more error handling: user input, case-insensitive Exe #5

Closed idbrii closed 3 years ago

idbrii commented 3 years ago

Thanks for creating this great tool!

After not reading instructions well enough, I added some error handling to make it a bit friendlier.

I also added some handling around the Exe key in shortcuts. Looks like UWPHook (steamsync for Windows Store) uses 'exe' instead of 'Exe' which causes some false positive warnings.

If you want me to exclude some of the commits from this PR, let me know!

jaydenmilne commented 3 years ago

Thanks for the PR! Glad that someone is finding it useful, it is definitely rough around the edges. LGTM

jaydenmilne commented 3 years ago

Just noticed without your changes I'm having the same issue, but I'm on python 3.9 now. Wonder if that's it?

jaydenmilne commented 3 years ago

Shipped in 0.2.5

idbrii commented 3 years ago

Just noticed without your changes I'm having the same issue, but I'm on python 3.9 now.

You mean you're still getting this warning:

Warning: Entry in shortcuts.vdf has no Exe field!

I'm on Python 3.9.1 and I'm not seeing it anymore.

BTW thanks for the quick merge! I installed on another PC and was delighted to see my steam path error message pop up. 😁