jaydenseric / extract-files

A function to recursively extract files and their object paths within a value, replacing them with null in a deep clone without mutating the original value. FileList instances are treated as File instance arrays. Files are typically File and Blob instances.
https://npm.im/extract-files
MIT License
56 stars 23 forks source link

Webpack 5 support #15

Closed dgomez-orangeloops closed 4 years ago

dgomez-orangeloops commented 4 years ago

CRA with webpack config:

Module not found: Error: Can't resolve 'extract-files/public/ReactNativeFile' Module not found: Error: Can't resolve 'extract-files/public/extractFiles' Module not found: Error: Can't resolve 'extract-files/public/isExtractableFile'

Please, review this issue: https://github.com/jaydenseric/apollo-upload-client/issues/230#issuecomment-709677574

thanks!

jaydenseric commented 4 years ago

I think you have it the other way around, you should raise an issue with CRA or webpack about extract-files support. The burden is on them to be able to resolve standard Node.js packages that Node.js itself is able to resolve just fine:

Screen Shot 2020-10-16 at 12 58 32 pm
jaydenseric commented 4 years ago

Also, I'm a little confused by your issue title Webpack 5 support when in the description you say CRA with webpack config – CRA doesn't use webpack v5 yet.