search

jaydenseric / graphql-multipart-request-spec

A spec for GraphQL multipart form requests (file uploads).
994 stars 54 forks source link

Batched mutations #2

Closed jeroenvisser101 closed 6 years ago

jeroenvisser101 commented 6 years ago

Hi @jaydenseric,

I'm looking to implement this spec into Absinthe's upload handling. I'm just confused by the following:

{
  "1": [
    "0.variables.image",
    "variables.images.0"
  ],
  "2": [
    "variables.images.1"
  ],
  "3": [
    "variables.images.2"
  ]
}

Either there's something else going on, or some of these mappings don't have the operation index prefixed in their key. I think it should be like this instead:

{
  "1": [
    "0.variables.image",
    "1.variables.images.0"
  ],
  "2": [
    "1.variables.images.1"
  ],
  "3": [
    "1.variables.images.2"
  ]
}

Can you let me know what is the correct way? Thanks for all your work on the client, server and this spec 👍

jaydenseric commented 6 years ago

Yes, you're right! Thats a nasty typo 😅

jeroenvisser101 commented 6 years ago

Not a problem, you want me to submit a PR for it?

jaydenseric commented 6 years ago

Yes please!

jeroenvisser101 commented 6 years ago

@jaydenseric it's in, #3, also, thanks for the super quick response!