search

jaydenseric / graphql-upload

Middleware and a scalar Upload to add support for GraphQL multipart requests (file uploads via queries and mutations) to various Node.js GraphQL servers.
https://npm.im/graphql-upload
MIT License
1.43k stars 132 forks source link

Handle and reject parsing errors #119

Closed edevil closed 6 years ago

edevil commented 6 years ago

I've noticed https://github.com/apollographql/apollo-upload-server/pull/2 which is a PR to a fork of this project that claims to fix a behaviour regarding handling of errors. Since the code mentioned is still present on this project I was wondering if this should be fixed here.

mike-marcacci commented 6 years ago

Hi @edevil, thanks for the note! This is already handled here along with a large number of other fixes and improvements.

edevil commented 6 years ago

@mike-marcacci Oh. A function called exit seems highly likely to kill the process, so I was tricked by the name. :)

mike-marcacci commented 6 years ago

Ah yes, possibly not the best name on my part given that other languages do use it to actually exit the program :)