search

jaydenseric / graphql-upload

Middleware and a scalar Upload to add support for GraphQL multipart requests (file uploads via queries and mutations) to various Node.js GraphQL servers.
https://npm.im/graphql-upload
MIT License
1.43k stars 132 forks source link

Fix and test for invalid `operations` and `map` field types #139

Closed MickVanDuijn closed 5 years ago

MickVanDuijn commented 5 years ago

When operations is of type string, and operationsPath.set is called, the error was not correctly propagated.

jaydenseric commented 5 years ago

Thanks for bringing this up! I've handled a few issues (e.g. null is technically an object but should not be allowed for operations) and polished some things.

I'll take it from here, as the map field needs the same treatment. I've added a todo test.

MickVanDuijn commented 5 years ago

Thanks! This at least solved one of the problems I had, but null is another tricky one indeed! What would be the ETA for this to be in a new release?

jaydenseric commented 5 years ago

@MickVanDuijn I plan to release today.

jaydenseric commented 5 years ago

Thanks 🙌

jaydenseric commented 5 years ago

Published in v8.0.5 🚀

MickVanDuijn commented 5 years ago

🚀 Thanks for the quick release!