Closed jaydenseric closed 4 years ago
fs-capacitor
currently has TypeScript related build errors, but when checking it out locally it seems the actual tests are passing in Node.js v14. Either those tests are missing something, or the problem is not with fs-capacitor
.
Ok, the problem relates to the ignoreStream
function:
https://github.com/jaydenseric/graphql-upload/blob/v10.0.0/lib/ignoreStream.js#L10
The issue surfaces in these tests:
https://github.com/jaydenseric/graphql-upload/blob/v10.0.0/test/lib/ignoreStream.test.js
Turned out to only be an issue with the tests; the published code was ok.
At the moment, the
graphql-upload
tests are failing for Node.js v14:https://github.com/jaydenseric/graphql-upload/runs/701487224?check_suite_focus=true#step:4:82
The error is:
Is it because of this in
fs-capacitor
?:https://github.com/mike-marcacci/fs-capacitor/blob/45ab8cb354a90914ce87c0069273ff40ff20654e/src/index.ts#L28
See https://github.com/mike-marcacci/fs-capacitor/issues/28 .
Does it relate to this Node.js v14 change?:
https://github.com/nodejs/node/pull/31912
Here are the Node.js v14 release notes:
https://nodejs.org/en/blog/release/v14.0.0/