search

jaydenseric / graphql-upload

Middleware and a scalar Upload to add support for GraphQL multipart requests (file uploads via queries and mutations) to various Node.js GraphQL servers.
https://npm.im/graphql-upload
MIT License
1.43k stars 132 forks source link

update object-path to latest version #263

Closed lolopinto closed 3 years ago

lolopinto commented 3 years ago

there's a github advisory about a security fix and it affects downstream clients.

updating this means clients can just update to latest version of this and get the change https://github.com/advisories/GHSA-cwx2-736x-mf6w

CVE-2021-23434
moderate severity
Vulnerable versions: < 0.11.6
Patched version: 0.11.6
This affects the package object-path before 0.11.6. A type confusion vulnerability can lead to a bypass of CVE-2020-15256 when the path components used in the path parameter are arrays. In particular, the condition currentPath === 'proto' returns false if currentPath is ['proto']. This is because the === operator returns always false when the type of the operands is different.

npm test passes

jaydenseric commented 3 years ago

See https://github.com/jaydenseric/graphql-upload/issues/261#issuecomment-915846860 .