jaydenseric / graphql-upload

Middleware and an Upload scalar to add support for GraphQL multipart requests (file uploads via queries and mutations) to various Node.js GraphQL servers.
https://npm.im/graphql-upload
MIT License
1.42k stars 131 forks source link

refactor: Make `graphql-upload` great again πŸ‡ΊπŸ‡Έ #376

Closed bnussman closed 11 months ago

bnussman commented 11 months ago

Why ❓

Description ✍🏼

Notes and Disclaimers πŸ—’οΈ ⚠️

Next steps βœ…

  1. Get @jaydenseric to admit this is much better than what this repo currently does
  2. If we accomplish step 1, we can make this PR more "production ready"
jaydenseric commented 11 months ago

Closing, as per https://github.com/jaydenseric/graphql-upload/pull/376#pullrequestreview-1542160750 .

bnussman commented 11 months ago

Thank you for that very interesting perspective. Also, thank you for your time and development of this package. I respect your work and I do not intend to infringe on anything. Please let me know if these is any action I need to take to do so.

Also, thank you for the critical code review. While I disagree with some things, I learned your viewpoint and reason for doing things the way you do them.