search

jaydenwindle / decode2017

One awesome shopify giveaway app developed at decode 2017!
Apache License 2.0
4 stars 1 forks source link

Changed layout of the enter form and confirm #32

Closed JKirkYuan closed 7 years ago

JKirkYuan commented 7 years ago

Feel free to drop a few comments. I changed up the two pages, test it out and let me know some problems and I'll try to fix them!

karimsa commented 7 years ago

Swap out all the uses of px for rems - Bootstrap 4 sets proper breakpoints for font-size on <body>.

karimsa commented 7 years ago

And improved spacing. Maybe push it through a CSS beautifier to fix whitespacing.

jaydenwindle commented 7 years ago

@karimsa px is fine for now, we can change it to rem after the demo tomorrow.

karimsa commented 7 years ago

Yes, but the issue should be addressed at some point.

vikrambombhi commented 7 years ago

@karimsa can u make it a issue so we get back to it at some point

vikrambombhi commented 7 years ago

This looks good to me(although admittedly i have no sense of design). Id say merge it to master for tomorrow and throw any further issues on the backlog(unless its build breaking)