Changed css to rem from px (fix #33)

jaydenwindle / decode2017

One awesome shopify giveaway app developed at decode 2017!

Apache License 2.0

4 stars 1 forks source link

Changed css to rem from px (fix #33) #52

Closed JKirkYuan closed 7 years ago

JKirkYuan commented 7 years ago

Description

Nothing special, converted all uses of px to rem

Motivation and Context

See issue #33

How Has This Been Tested?

N/A

Screenshots (if appropriate):

N/A

Types of changes

[ x ] Bug fix (non-breaking change which fixes an issue)
[ - ] New feature (non-breaking change which adds functionality)
[ - ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ x ] My code follows the code style of this project.
[ - ] My change requires a change to the documentation.
[ - ] I have updated the documentation accordingly.

karimsa commented 7 years ago

Looks good - can you try to figure out how we could use something like mappy-breakpoint to handle breakpoints? Or can we take the breakpoints defined by bootstrap and turn them into a separate SASS file with variables?

JKirkYuan commented 7 years ago

I think we can actually define variables ourselves and use those values as media breakpoints shown here, do you think that would be a good alternative to mappy-breakpoints? It's kind of weird because when I tried to use their syntax, nothing was working :/

karimsa commented 7 years ago

Yeah, I think that's best. Let's use the breakpoints from Bootstrap, but put them into our own variables.

screen shot 2017-04-14 at 11 52 18 am

Something to the effect of this.

karimsa commented 7 years ago

Also, for future PRs, follow the contribution guide for naming branches.