jaydenwindle / decode2017

One awesome shopify giveaway app developed at decode 2017!
Apache License 2.0
4 stars 1 forks source link

Fixed choosing and saving of winners (fix #36) #59

Closed jaydenwindle closed 4 years ago

jaydenwindle commented 7 years ago

Description

Motivation and Context

Fixes #36 and removes the terrible hack that was previously used to display the name of the product a user won in the giveaway#show method

How Has This Been Tested?

Manual testing

Screenshots (if appropriate):

screencapture-shopify-giveaway-demo-1-myshopify-admin-apps-d6fa4ff7f2cbfa071b2a04f5a60ebe8a-1492638730410 WInners showing correctly in front end

Types of changes

Checklist:

karimsa commented 7 years ago

There's syntax errors in the JS in both winners.html.erb and show.html.erb. The inline JS that is instantiating the Shopify app: the title should be a string.

jaydenwindle commented 7 years ago

@karimsa I'll fix the syntax errors in #60