search

jaydenwindle / decode2017

One awesome shopify giveaway app developed at decode 2017!
Apache License 2.0
4 stars 1 forks source link

Linter/syntax checker #61

Open vikrambombhi opened 7 years ago

vikrambombhi commented 7 years ago

Expected Behavior

We should get a linter/syntax checker. It seems like alot of the requested issues on PR's are small syntax issues. Basic syntax things like spacing and semicolons can be taken care of by a linter and we can concentrate our reviews on the logic of the code.

Current Behavior

Most PR reviews are syntax change requests not logic.

Possible Solution

Some sort of linter. Im sure rails has something like this but we have to find it/decide on which one to use.

jaydenwindle commented 7 years ago

Good call. Is there a style guide check / linter we can add to our travis ci?

karimsa commented 7 years ago

I normally do this via node.js, but there's probably some sort of bridge to set it up for rails.

I'll have a look soon.