Handle connection_init and connection_terminate

jaydenwindle / graphene-subscriptions

A plug-and-play GraphQL subscription implementation for Graphene + Django built using Django Channels.

MIT License

115 stars 15 forks source link

Handle connection_init and connection_terminate #19

Open fdev opened 4 years ago

fdev commented 4 years ago

When using Apollo Client (specifically subscriptions-transport-ws) the websocket client expects either a connection_ack or connection_error response from the server after sending the initial connection_init message.

Currently, graphene-subscriptions just ignores these message types which causes the client to never emit connected events and may cause a maxConnectTime trigger to be performed.

jaydenwindle commented 4 years ago

Thanks a ton for the PR @fdev! I'd love to merge this in.

Would you mind adding some unit tests as well?

fdev commented 4 years ago

Thanks for the quick response @jaydenwindle. I have added tests and squashed a bug in the process.

By the way, I'm getting warnings about the id variable overriding a built-in Python function.

qwaqwa93TW commented 2 years ago

@jaydenwindle Why is this PR not being merged? I am suffering from that timeout problem

wnaldj1589TW commented 2 years ago

Is anyone watching this issue?