search

jaydevchotalia / DesiTadka-Jaydev

0 stars 0 forks source link

Feedback #1

Open 40x opened 9 years ago

40x commented 9 years ago
  1. Do not use !important, if you have to use that then something is wrong with the way you have written your css
  2. Avoid using * in css its bad for performance
  3. Do not hardcode css values width: 405px
  4. max-width should not be used for making your app responsive, follow mobile first approach and use only min-width
  5. Add form validations for reservations
  6. avoid using classes like margin-0 and margin-top-20 you can arrange your elements neatly using bootstrap itself
  7. bootstrap has text-left so no need to use text-align-left
  8. remove footer instead of leaving it blank
jaydevchotalia commented 9 years ago

Hello Kashyap, Thanks for the feedback , I would update the project with the changes you recommended. Kashyap is it fine if I change few things on this project because I learned few stuff from which I can improve my project.

Regards, Jaydev Chotalia

On Wed, Jul 22, 2015 at 5:21 PM, Kashyap Mukkamala <notifications@github.com

wrote:

  1. Do not use !important, if you have to use that then something is wrong with the way you have written your css
  2. Avoid using * in css its bad for performance
  3. Do not hardcode css values width: 405px
  4. max-width should not be used for making your app responsive, follow mobile first approach and use only min-width
  5. Add form validations for reservations
  6. avoid using classes like margin-0 and margin-top-20 you can arrange your elements neatly using bootstrap itself
  7. bootstrap has text-left so no need to use text-align-left
  8. remove footer instead of leaving it blank

— Reply to this email directly or view it on GitHub https://github.com/jaydevchotalia/DesiTadka-Jaydev/issues/1.