Build error under OSX Lion

[GoogleCodeExporter]

What steps will reproduce the problem?
normal build and installation 

What is the expected output? What do you see instead?
cc -c -DROOT="/Users/ericvh/src/inferno-os" -DOBJTYPE="386" -DEMU -I. -I../port 
-I/Users/ericvh/src/inferno-os/MacOSX/386/include 
-I/Users/ericvh/src/inferno-os/include -I/Users/ericvh/src/inferno-os/libinterp 
-arch i386 -mmacosx-version-min=10.4 -Wno-deprecated-declarations 
-Wuninitialized -Wunused -Wreturn-type -Wimplicit -Wno-four-char-constants 
-Wno-unknown-pragmas -pipe -fno-strict-aliasing -no-cpp-precomp -mno-fused-madd 
-I/Users/ericvh/src/inferno-os/MacOSX/386/include 
-I/Users/ericvh/src/inferno-os/include -Os win.c
win.c: In function ‘winproc’:
win.c:167: warning: implicit declaration of function ‘InitCursor’
win.c: In function ‘MainWindowCommandHandler’:
win.c:528: warning: implicit declaration of function ‘GetPortBounds’
win.c: In function ‘drawcursor’:
win.c:733: error: ‘Cursor’ undeclared (first use in this function)
win.c:733: error: (Each undeclared identifier is reported only once
win.c:733: error: for each function it appears in.)
win.c:733: error: expected ‘;’ before ‘crsr’
win.c:741: error: ‘crsr’ undeclared (first use in this function)
win.c:765: warning: implicit declaration of function ‘SetCursor’
mk: cc -c -DROOT="/Users/ericvh/src/inferno-os" ...  : exit status=exit(1)
mk: echo "(cd $SYSTARG; ...  : exit status=exit(1)
mk: for j in ...  : exit status=exit(1)

Which operating system are you using?
MacOSX Version 10.7

Please provide any additional information below.

Original issue reported on code.google.com by eri...@gmail.com on 31 Jul 2011 at 7:17

[GoogleCodeExporter]

I am sorry I made a joke about Apple and Android on Google+ recently. Clearly, 
I deserved this. Must find out what has now changed ...

Original comment by Charles....@gmail.com on 31 Jul 2011 at 9:02

• Changed state: Accepted

[GoogleCodeExporter]

I believe this is related to the removal of the QuickDraw API in OSX 10.7.

see: 
http://developer.apple.com/legacy/mac/library/#documentation/Carbon/Reference/Qu
ickDraw_Ref/Reference/reference.html for deprecation notices

Some discussion at stackoverflow: 
http://stackoverflow.com/questions/8154444/xcode-3-4-causing-errors

Original comment by nat...@gmail.com on 13 Apr 2012 at 4:58

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I've removed some quickdraw stuff from the drawcursor function and replaced 
with quartz functions. someone please test. I compiled on my 10.7 system and 
ran acme successfully so it does appear to work.

-- edited, took out unused variables --

Original comment by nat...@gmail.com on 13 Apr 2012 at 7:09

Attachments:

• MacOSX-quartz.patch

[GoogleCodeExporter]

The first one works well, will check the second patch.

Thanks!

Em 13/04/2012, �s 15:52, inferno-os@googlecode.com escreveu:

Original comment by xspager on 13 Apr 2012 at 7:22

[GoogleCodeExporter]

Of course! i made several revisions to remove unused code, ended up slimming 
the whole drawcursor function down quite a bit. Hopefully I helped! :)

Original comment by nat...@gmail.com on 13 Apr 2012 at 7:24

[GoogleCodeExporter]

A lot! Well done!

Em 13/04/2012, �s 16:24, inferno-os@googlecode.com escreveu:

Original comment by xspager on 13 Apr 2012 at 7:27

[GoogleCodeExporter]

I think is better leave this function body empty. It is moving the cursor to to 
left top of the screen every time i click. Since the cursor is draw by OSX, i 
think is not an issue. 

Original comment by xspager on 15 Apr 2012 at 8:47

[GoogleCodeExporter]

Sounds like a good idea. I didn't track down where else that function gets 
called but if leaving it empty satisfies the requirements it sounds good.

Original comment by nat...@gmail.com on 15 Apr 2012 at 10:14