jayduhon / inferno-os

Automatically exported from code.google.com/p/inferno-os
2 stars 0 forks source link

Linux/arm build broken #297

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

Run 'mk install' in inferno root

What is the expected output? What do you see instead?

gcc -c -O -Wuninitialized -Wunused-variable -Wreturn-type -Wimplicit 
-I/home/pi/inferno-os/Linux/arm/include -I/home/pi/inferno-os/include 
-DLINUX_ARM comp-arm.c
comp-arm.c: In function ‘comp’:
comp-arm.c:1569:27: error: macro "LDRW" requires 5 arguments, but only 4 given
comp-arm.c:1569:5: error: ‘LDRW’ undeclared (first use in this function)
comp-arm.c:1569:5: note: each undeclared identifier is reported only once for 
each function it appears in
mk: gcc -c -O ...  : exit status=exit(1)
mk: for j in ...  : exit status=exit(1)

This was clearly introduced by the recent rune changes:

changeset:   564:69dd46e5bad5
user:        Charles Forsyth <charles.forsyth@gmail.com>
date:        Tue Jun 04 08:30:04 2013 +0000
summary:     adjust code to size of Runes

Original issue reported on code.google.com by fshahr...@gmail.com on 22 Jun 2013 at 3:23

GoogleCodeExporter commented 9 years ago
Yes, that was careless. Try                 LDRW(LT, RA1, RA3, 0, RA2);
although it's inefficient, and some nearby code (not changed for years) doesn't 
look quite right to me now.

Original comment by Charles....@gmail.com on 22 Jun 2013 at 11:53

GoogleCodeExporter commented 9 years ago
That fixed the build at least. Thanks.

Original comment by fshahr...@gmail.com on 23 Jun 2013 at 4:24