Improved readme and fixed crash for empty image source

jayesbe / react-native-cacheable-image

An Image Component for React Native that will cache itself to disk.

MIT License

304 stars 78 forks source link

Improved readme and fixed crash for empty image source #29

Closed eugenehp closed 7 years ago

eugenehp commented 7 years ago

Fixed crashes when uri is empty:

<CacheableImage source={{uri:''}}/>

jayesbe commented 7 years ago

@eugenehp I'm going to cherry pick your changes to leave out Nathan's changes.

eugenehp commented 7 years ago

@jayesbe sounds good. let me know if you need any help with it.

jayesbe commented 7 years ago

@eugenehp added your readme changes and empty source fix. I left out nathan's changes for now.. seeking a better option.

jayesbe commented 7 years ago

Yup already pushed 1.4.3

eugenehp commented 7 years ago

Awesome!

On Sat, Nov 26, 2016 at 2:33 AM, Jesse notifications@github.com wrote:

Yup already pushed 1.4.3

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jayesbe/react-native-cacheable-image/pull/29#issuecomment-263056206, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxW723NynDG0Z1hRDHC3eOq99egfyNcks5rCAr4gaJpZM4K80b3 .