search

jayesbe / react-native-cacheable-image

An Image Component for React Native that will cache itself to disk.
MIT License
304 stars 78 forks source link

Set "react-native-response-image" dependency to ^2.2.0 #62

Closed blake-simpson closed 6 years ago

blake-simpson commented 6 years ago

It would be useful to have version 2 of react-native-response-image within react-native-cacheable-image as various upgrades have been applied to props applied the raw <Image /> component that the responsive image uses. As cacheable image only passes the props through to responsive image, I think there should be no compatibility issues, since they have not removed any of the original props, only added more.

I need this for example to pass the borderRadius prop down to the raw react-native <Image /> which with the current dependencies is not possible.

jayesbe commented 6 years ago

@BlakeSimpson the dev branch has upgraded the dependency to ^2.0.0 for responsive image.

jayesbe commented 6 years ago

I dont mind upgrading master to v2 though

blake-simpson commented 6 years ago

Thanks a lot for really fast reaction @jayesbe! Would you also be able to quickly push a release to NPM? I would appreciate having a fixed version to work with instead of a git repo.

jayesbe commented 6 years ago

@BlakeSimpson not at the moment.. will publish a new version by tomorrow morning.. would a tag help for now ?

blake-simpson commented 6 years ago

@jayesbe If it is tomorrow morning then I could wait until then. Just let me know. Thanks a lot!

jayesbe commented 6 years ago

@BlakeSimpson published

blake-simpson commented 6 years ago

@jayesbe Thanks a lot!