jayesbe / react-native-cacheable-image

An Image Component for React Native that will cache itself to disk.
MIT License
304 stars 78 forks source link

Usage of NetInfo through react-native #69

Closed rasmniel closed 4 years ago

rasmniel commented 5 years ago

Given the react-native-netinfo repository has been created to modularize dependencies of React Native, I think react-native-cacheable-image should comply with this modularization by including the new NetInfo repository as a dependency. Better sooner than later ;)

Furthermore, this alleviates the annoyance of having to mute the warning produced by React Native in newer versions (I'm unsure at which version RN starts printing this warning):

Warning: NetInfo has been extracted from react-native core and will be removed in a future release. It can now be installed and imported from '@react-native-community/netinfo' instead of 'react-native'. See https://github.com/react-native-community/react-native-netinfo

jayesbe commented 4 years ago

Fixed with latest merge