search

jayesbe / react-native-cacheable-image

An Image Component for React Native that will cache itself to disk.
MIT License
304 stars 78 forks source link

Can't we use ProgressViewIOS instead of ProgressBarAndroid? #7

Closed scerelli closed 8 years ago

scerelli commented 8 years ago

I saw that you using a progress bar for android and none for IOS. What do you think if we use this for ios: https://facebook.github.io/react-native/docs/progressviewios.html

so we will support both Platforms

jayesbe commented 8 years ago

Yes most definitely. I had no way to test iOS so I chose not to implement it. If you can add it in that would be very much appreciated.

Originally I thought maybe create imageProgress.android.js and imageProgress.ios.js and put the specific progress loaders in respective files. Then import ImageProgress element. But I am open to any decent working implementation.

scerelli commented 8 years ago

Ok give me some time. I think tomorrow i can fix it

jayesbe commented 8 years ago

Take your time :) and thanks for the help.

jayesbe commented 8 years ago

@scerelli merged in @fluciotto PR that changes the ProgressView to ActivityIndicator