Update for Rails 5 - Githubissues

jayfajardo / openlibrary

Ruby Interface for the OpenLibrary API

94 stars 37 forks source link

Closed flyinggrizzly closed 6 years ago

flyinggrizzly commented 7 years ago

This PR updates updates:

RSpec to 3.6
RSpec syntax (using Transpec
Ruby version to 2.2.2 to match min for Rails 5
ActiveSupport to 5
Webmock to 3, to resolve the StubSocket#close deprecation for Ruby 2.4
Gem version to 3.0.0, because this will not work for anyone still using 2.x.x and Rails 4

This has been tested on Ruby 2.2.2, 2.2.7 (latest 2.2), 2.3.4 (latest 2.3), and 2.4.1 (latest 2.4).

This addresses issue 28 (cc @thomasconnolly).

flyinggrizzly commented 7 years ago

For anyone who needs this before the PR gets reviewed, I'm keeping a protected rails-5 branch in my fork.