Refactor Dependency Injection in Controllers to Constructor Injection

jaygajera17 / E-commerce-project-springBoot

This project serves as an easy-to-understand setup for beginners , providing a base foundation in Spring Boot , MVC & hibernate.

https://jaygajera17.github.io/E-commerce-project-springBoot/

587 stars 600 forks source link

Refactor Dependency Injection in Controllers to Constructor Injection #74

Closed Grad566 closed 2 months ago

Grad566 commented 3 months ago

Hey! I believe it's better to implement dependency injection in controller classes using constructors instead of field injection. I could use Lombok to simplify this, or I could do it manually by explicitly defining the constructors. Can I work on it?

Grad566 commented 3 months ago

Hi @NisargPipaliya! Could you please reply to me?

NisargPipaliya commented 3 months ago

Hey @Grad566 Sorry for late reply. That's a great idea, You can start working on the issue. You have 14 days to complete the task, all the best 👍

Grad566 commented 2 months ago

Hey! I have completed the changes. Could you please check my pull request at the following link? Pull Request #75

NisargPipaliya commented 2 months ago

Great Work, @Grad566