jayhxmo / notion-icons

(Unofficial) Use custom icon sets in Notion directly
MIT License
37 stars 2 forks source link

Icon tab doesn't show up on Chrome for Windows #4

Open MiracleXYZ opened 5 years ago

MiracleXYZ commented 5 years ago

I use Chrome for Windows. After I installed this extension on Chrome Store, icon tab just doesn't show up. Dragging this repository directly into developers mode doesn't help either.

Got an error message here: image

jayhxmo commented 5 years ago

Thanks for the bug report. There's currently a bug with the extension not working on full-width pages or popups. Can you confirm if this is happening on a normal / narrow page?

MiracleXYZ commented 5 years ago

Thanks for the reply. But it doesn't work on ALL pages, including normal page & collections & full-width pages & popups. In details:

Normal page: No icon tab, an error message shows up. Collections (databases): No icon tab, no error messages. Full-width pages: No icon tab, no error messages. Popups: No icon tab, no error messages.

It's a bit... weird 🤔

BTW my chrome version is 74.0.3729.169 (64-bit).

jayhxmo commented 5 years ago

Weird.. note that it requires a "refresh" between pages if there is an error that breaks it (since it is written in JavaScript afterall, and Notion is a single-page app)

Does this error message happen as soon as you load? Or after you click on the Icons to show the pop-up?

MiracleXYZ commented 5 years ago

I refresh multiple times in a single page, and the results tend to be the same.

The error message happens after I click on the icons to show the pop-up.

jayhxmo commented 5 years ago

I see. Thanks for the details. Does it happen for a freshly made, new page as well?

(This is a bit more challenging because Notion does not use any class names or IDs to represent DOM elements... all needs to be done through just hierarchy matching and style check)

MiracleXYZ commented 5 years ago

I see...

It doesn't work for a freshly made new page as well. 😢

(It's challenging to make extensions of Notion... Thanks for your contribution.)