jayjanssen / Percona-Pacemaker-Resource-Agents

Pacemaker HA Resource Agents by Percona
28 stars 9 forks source link

Syntax bug #4

Open kissze opened 11 years ago

kissze commented 11 years ago

Hi! There is a syntax bug in the mysql resource manager script. CRM log: Dec 23 16:02:23 tsql1 crmd: [23037]: info: ais_dispatch_message: Membership 96: quorum retained Dec 23 16:02:23 tsql1 lrmd: [23034]: info: rsc:p_mysql:0 probe[22](pid 30444) Dec 23 16:02:23 tsql1 lrmd: [23034]: info: RA output: (p_mysql:0:probe:stderr) /usr/lib/ocf/resource.d//percona/mysql: 595: /usr/lib/ocf/resource.d//percona/mysql: Dec 23 16:02:23 tsql1 lrmd: [23034]: info: RA output: (p_mysql:0:probe:stderr) Syntax error: word unexpected (expecting "fi") Dec 23 16:02:23 tsql1 lrmd: [23034]: info: RA output: (p_mysql:0:probe:stderr) Dec 23 16:02:23 tsql1 lrmd: [23034]: info: operation monitor[22] on p_mysql:0 for client 23037: pid 30444 exited with return code 2 Dec 23 16:02:23 tsql1 crmd: [23037]: info: process_lrm_event: LRM operation p_mysql:0_monitor_0 (call=22, rc=2, cib-update=31, confirmed=true) invalid parameter

Please correct it, because the resource agent not working. I made a little correction (deleted two brackets near the problematic line), but it wold be nice if it repaired by the official developer.

Thanks!

Zoltan

jburnham commented 11 years ago

Hi Zoltan, can you see if https://github.com/jburnham/resource-agents-prm/commit/c051e1593444da8cfc1cf7d49c7769c7d9361741 fixes the issue? It seems you may be using /bin/sh which on some operating systems is a symlink to /bin/dash (Debian, Ubuntu). I tested this issue myself and was able to replicate the error message with some test code. I found an existing debian bug report and implemented the workaround. I opened the pull request to merge it into master https://github.com/y-trudeau/resource-agents-prm/issues/11

Thanks.

kissze commented 11 years ago

Hi! It's working now on Debian Wheezy amd64 without any error. Thanks for the workaround.

jburnham commented 11 years ago

https://github.com/y-trudeau/resource-agents-prm/issues/11 was merged. This issue can now be closed in my opinion.