search

jayjanssen / vagrant-percona-deprecated

Vagrant setup to launch Percona Server or PXC on virtualbox or AWS
19 stars 14 forks source link

Linking to Vagrantfile less optimal, causing nodes to linger on for people like me #1

Closed grypyrg closed 11 years ago

grypyrg commented 11 years ago

I placed all Vagrantfiles in environments/, each in their own subdirectory.

Why?

  1. relink the Vagrantfile, if there are less nodes or different nodenames, you kinda lose the status of them and they are just lost in space. I could have made a wrapper around it... but I thought that was ugly and think this approach is better.
  2. linking is just not fun

One downside now is that pxc-bootstrap.sh fits 2 environments, so that's why I kept it in the root.

Kenny

jayjanssen commented 11 years ago

I see what you're trying to accomplish. I really mean for this repo to be setup as a submodule to some other repo for you to create your custom environments in and for the Vagrantfiles to be examples and the puppet manifests to be generic enough reuse without serious modification.

Also I use the fact that the .vagrant files are in the same directory in the PXC tutorial (https://github.com/percona/xtradb-cluster-tutorial/tree/v2) to make it easy to change the same vagrant nodes from master/slave to PXC by just changing the symlink., though of course there it's a separate repo and certainly it's easy enough to set it up that way just there.

I'll mull this over a bit.

grypyrg commented 11 years ago

Yeah, didn't know about the submodule. Anyway, if you think Vagrantfile.* is the way to go. I made https://github.com/grypyrg/vagrant-percona-playground by using submotules