search

jayjanssen / vagrant-percona-deprecated

Vagrant setup to launch Percona Server or PXC on virtualbox or AWS
19 stars 14 forks source link

undef experimental_repo and percona_server_version settings don't work right #3

Closed jayjanssen closed 10 years ago

jayjanssen commented 10 years ago

I pushed a few commits to work around this, but it appears in the code this was supposed to be have been supported.

These patches could be removed if there is a cleaner way, but it should not be explicitly necessary to specify these two variables from the Vagrantfile.

https://github.com/jayjanssen/vagrant-percona/commit/c6cf4d5aed6c24cdce34c237e39524bf5ff9327e https://github.com/jayjanssen/vagrant-percona/commit/e4e09e7c112df038e346e5b64dd7cc2e87d3223c

jayjanssen commented 10 years ago

To be clear: without these patches or explicit definitions of these in my vagrantfile, I will get errors on provisioning.

grypyrg commented 10 years ago

I just removed my 'default' for the experimental repo. Yours works, so let's use that :).

grypyrg commented 10 years ago

I would close the issue as it seems to work now.

One big issue I have is that percona-server-server-55 and percona-server-server-56 conflict with eachother, so I did ugly things to resolve this when reprovisioning from 55 -> 56 and vice-versa. So I think we can just leave it as is now, your code to set defaults work, and if we change the puppet code, we can look for other ways.