search

jayjaybillings / fire

Repository for the Fire framework
Other
0 stars 2 forks source link

Building master fails at NetworkIntegrationTest #15

Closed amccaskey closed 7 years ago

amccaskey commented 7 years ago

Build fails in master if building from README instructions. Pulling down Fire and running cmake and make results in 

In file included from /projects/test/fire/astrophysics/tests/NetworkIntegrationTest.cpp:40:0:
/projects/test/fire/solvers/ODESolver.h:35:36: fatal error: nvector/nvector_serial.h: No such file or directory
 #include <nvector/nvector_serial.h>
                                    ^
compilation terminated.

Are SUNDIALS/BLAS/LAPACK now required dependencies?

jayjaybillings commented 7 years ago

Hm. They are not required unless you want to build the astrophysics bundle. The solvers package will just skip them if they are not available.

I think we need to find a way to turn off bundles so that you are not trying to build the astrophysics bundle for your quantum work. Thoughts?

amccaskey commented 7 years ago

Yea I'd like a way to specifically turn on a bundle, and have it off otherwise.

I noticed though there is no check in the astrophysics/CMakeLists file for the presence of those solver packages...

jayjaybillings commented 7 years ago

Well, yeah, I'm not done writing them yet. :-)

amccaskey commented 7 years ago

temporary fix for this in 885fff7d1a363f794dd53559e9f52819665129db

jayjaybillings commented 7 years ago

So, my fix was actually quite a bit different than yours. I just checked for the existence of the solvers libraries because the idea is that there will be something there, but maybe not sundials. In general we want to maintain encapsulation.