jayjun / rambo

Run your command. Send input. Get output.
MIT License
199 stars 21 forks source link

Add possibility to pass `env` variables, like System.cmd #2

Closed philipgiuliani closed 4 years ago

philipgiuliani commented 4 years ago

System.cmd has the possibility to pass a keyword list of env variables for executing the command.

See: https://github.com/elixir-lang/elixir/blob/v1.10.2/lib/elixir/lib/system.ex#L730

It would be nice to also have this feature in Rambo!

jayjun commented 4 years ago

System.cmd accepts a list of string-string tuples, not a keyword list.

iex> Keyword.keyword?([{"MIX_ENV", "test"}])
false

Good news is, Rambo already accepts that and it‘s documented!

philipgiuliani commented 4 years ago

Oh, I looked for it but missed it 😅 Thank you!