search

jayjzheng / ff_rankings

fantasy footbal rankings
MIT License
46 stars 11 forks source link

Move draft click handler to player rows #4

Closed chrischernoff closed 10 years ago

chrischernoff commented 10 years ago

This is an awesome tool! I plan on using it for my draft today, however I had a small tweak I think makes drafting faster/easier. Instead of having to click on the player name to draft them, I'd rather just be able to click anywhere on their row.

In addition to moving the click handler to the row, I removed the anchor off the player name as they're not really "links".

Thanks again for putting this together!

jayjzheng commented 10 years ago

I kinda went back and forth on this. I think you do have a point of letting the user click anywhere on the row to draft. On the other hand, I also plan to add displaying more info when the user hovers/clicks on the row.

Not sure yet, what do you think?

chrischernoff commented 10 years ago

I think hover = show more details and click = draft is a fair paradigm.

jayjzheng commented 10 years ago

agreed.