Colouring in Draft Aid for PPR/0.5 PPR

jayjzheng / ff_rankings

fantasy footbal rankings

MIT License

46 stars 11 forks source link

Colouring in Draft Aid for PPR/0.5 PPR #6

Closed smc0407 closed 9 years ago

smc0407 commented 10 years ago

The colouring for the tiers is a little wonky when you switch to either of the PPR options in Draft Aid. This specifically can be seen in the T.E. column, where Tiers 1, 5, and 9 (which happened to encompass the first 4 TEs) are all green. I think something happened to the pink colour highlighting...

albertlyu commented 10 years ago

This seems to be expected with a recent commit, where color codes rotate every 4 tiers (see the modulo operations in 29bc834257e954af351afa43fc6d3bc1618ad82a).

jayjzheng commented 10 years ago

yeah, i think the colored tiers could be improved. Ideally, it should be generated dynamically based on number of the tiers the rankings have, with each tier having its own color.

jayjzheng commented 9 years ago

i can live with the rotating of 4 colors.